Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: table): resizable table with ScrollY #3746

Conversation

thirking
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#3725 | #3732

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix resizable table with ScrollY
🇨🇳 Chinese 修复带有ScrollY的可伸缩列表

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

github-actions bot commented Mar 20, 2024

@thirking thirking closed this Mar 20, 2024
@thirking thirking reopened this Mar 20, 2024
@ElderJames
Copy link
Member

Thanks for contribution @thirking , I found that it didn't work properly when setting up ScrollX and ScorllY at the same time.

table-scroll-resizable

@thirking
Copy link
Contributor Author

Thanks for contribution @thirking , I found that it didn't work properly when setting up ScrollX and ScorllY at the same time.

table-scroll-resizable

I solved part of the problem, but there are still some bugs:

  1. The left of the fixed column also needs to be modified according to the change of the column width;
  2. handle may be obscured by other columns.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 1.49%. Comparing base (e1ec721) to head (268aee8).

Files Patch % Lines
...s/core/JsInterop/modules/components/tableHelper.ts 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3746      +/-   ##
=========================================
- Coverage    1.49%   1.49%   -0.01%     
=========================================
  Files         575     575              
  Lines       27820   27825       +5     
  Branches     5621    5625       +4     
=========================================
  Hits          417     417              
- Misses      27363   27368       +5     
  Partials       40      40              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems work well. I'll merge it first. Please feel free to create another PR for the following enhancement.

@ElderJames ElderJames merged commit 158bb07 into ant-design-blazor:master Mar 21, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants