Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(button): add some button tests #460

Merged
merged 2 commits into from
Aug 5, 2020
Merged

test(button): add some button tests #460

merged 2 commits into from
Aug 5, 2020

Conversation

diegofrata
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

This is a starting point for creating a testing suite for AntDesign based on xUnit and bUnit. This PR adds some initial tests for the Button component. I'd love to see this merged and eventually being run as part of the build pipeline. If you're happy with this PR I might start contributing with tests.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@ElderJames
Copy link
Member

Thank you for your great contribution!🎉👏
We would be very grateful if you would like to help us improve this project!
We will review this PR and add test step for github actions in another PR as soon as possible.😊

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 1d96c84 into ant-design-blazor:master Aug 5, 2020
@diegofrata diegofrata deleted the test-suite-proposal branch August 5, 2020 09:12
Zhuangkh pushed a commit to Zhuangkh/ant-design-blazor that referenced this pull request Sep 25, 2020
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Oct 15, 2020
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants