Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: subscribe to js event listener #466

Merged
merged 2 commits into from
Aug 26, 2020
Merged

feat: subscribe to js event listener #466

merged 2 commits into from
Aug 26, 2020

Conversation

brian-ding
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Subscribe to the js event listener instead of calling js multiple times

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@brian-ding
Copy link
Contributor Author

  1. replace dictionary with concurrent dictionary
  2. add an optional flag to share js listener or not.

@brian-ding brian-ding closed this Aug 19, 2020
@brian-ding brian-ding reopened this Aug 25, 2020
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 18d697f into ant-design-blazor:master Aug 26, 2020
Zhuangkh pushed a commit to Zhuangkh/ant-design-blazor that referenced this pull request Sep 25, 2020
ElderJames added a commit that referenced this pull request Oct 15, 2020
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants