feat(module: confirm): support blocking to get the result of confirm #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimChen44
reviewed
Aug 9, 2020
components/modal/ModalRef.cs
Outdated
| @@ -92,5 +92,8 @@ public async Task UpdateConfig(ConfirmOptions config) | |||
| await _service?.Update(this); | |||
| } | |||
|
|
|||
| internal TaskCompletionSource<bool> TaskCompletionSource { get; set; } | |||
There was a problem hiding this comment.
此处bool修改成enum是否更好，便于将来的扩展。
Is it better to modify bool to enum here to facilitate future expansion.
Such as:
public enum ConfirmResult
{
None = 0,
OK = 1,
Cancel = 2,
Abort = 3,
Retry = 4,
Ignore = 5,
Yes = 6,
No = 7
}
There was a problem hiding this comment.
For the confirm component, there are only only two types of buttons: OK or Cancel
There was a problem hiding this comment.
Shall we put it in the generic ModalRef<T> ?
There was a problem hiding this comment.
如果是对于表单编辑关闭确认，就会存在“保存”，“不保存”，“取消”三个状态。
If it is to confirm the closing of the form editing, there will be three states of "Save", "Do not save" and "Cancel"。
zxyao145
force-pushed
the
taskCompletionSource
branch
from
d34b667
to
361fc7f
Compare
Zhuangkh
pushed a commit
to Zhuangkh/ant-design-blazor
that referenced
this pull request
Sep 25, 2020
…ign-blazor#476) * feat(module: confirm): support blocking to get the result of confirm * refactor: change modalservice Confirm return value,add ConfirmAsync FUNC * feat: add ConfirmService * fix: button text Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Oct 15, 2020
* feat(module: confirm): support blocking to get the result of confirm * refactor: change modalservice Confirm return value,add ConfirmAsync FUNC * feat: add ConfirmService * fix: button text Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* feat(module: confirm): support blocking to get the result of confirm * refactor: change modalservice Confirm return value,add ConfirmAsync FUNC * feat: add ConfirmService * fix: button text Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* feat(module: confirm): support blocking to get the result of confirm * refactor: change modalservice Confirm return value,add ConfirmAsync FUNC * feat: add ConfirmService * fix: button text Co-authored-by: ElderJames <shunjiey@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge