Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon list on demo of icon page #478

Merged
merged 16 commits into from
Aug 13, 2020

Conversation

1002527441
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • [ x] New feature
  • Bug fix
  • Site / documentation update
  • [ x] Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • [ x] Doc is updated/provided or not needed
  • [x ] Demo is updated/provided or not needed
  • Changelog is provided or not needed

@Epictek
Copy link
Member

Epictek commented Aug 9, 2020

/preview

@github-actions
Copy link

github-actions bot commented Aug 9, 2020

ElderJames
ElderJames previously approved these changes Aug 13, 2020
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@@ -14,7 +14,7 @@
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/docsearch.js@2.6.3/dist/cdn/docsearch.min.css" />
<link href="_content/AntDesign.Docs/css/docs.css" rel="stylesheet">

<script src="@("https://unpkg.com/@antv/g2plot@latest/dist/g2plot.js")"></script>
<script src="@("https://unpkg.zhimg.com/@antv/g2plot@latest/dist/g2plot.js")"></script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not part of this commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的,因为在unpkg.com经常晚上连结不到, 我改的国内镜像是用作调试的。

Zhuangkh pushed a commit to Zhuangkh/ant-design-blazor that referenced this pull request Sep 25, 2020
* feat: add icon list for demo page of icon

* feat: add copy function for icon list

* feat: get existed icon

* feat: remove some blanks in list.razor

* feat: remove some blanks

* fix: default value is outline for icon list

* fix: click to copy for icon list

* feat: add async to load icon list

* feat: update iconlistService

* chore: update icons

* fix: icon load async

* feat: add application icons in IconlistServices

* fix: remove the exist icon from existed catogory if duplicated

* fix: add @key for list items

* fix: revert the change

Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Oct 15, 2020
* feat: add icon list for demo page of icon

* feat: add copy function for icon list

* feat: get existed icon

* feat: remove some blanks in list.razor

* feat: remove some blanks

* fix: default value is outline for icon list

* fix: click to copy for icon list

* feat: add async to load icon list

* feat: update iconlistService

* chore: update icons

* fix: icon load async

* feat: add application icons in IconlistServices

* fix: remove the exist icon from existed catogory if duplicated

* fix: add @key for list items

* fix: revert the change

Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* feat: add icon list for demo page of icon

* feat: add copy function for icon list

* feat: get existed icon

* feat: remove some blanks in list.razor

* feat: remove some blanks

* fix: default value is outline for icon list

* fix: click to copy for icon list

* feat: add async to load icon list

* feat: update iconlistService

* chore: update icons

* fix: icon load async

* feat: add application icons in IconlistServices

* fix: remove the exist icon from existed catogory if duplicated

* fix: add @key for list items

* fix: revert the change

Co-authored-by: ElderJames <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* feat: add icon list for demo page of icon

* feat: add copy function for icon list

* feat: get existed icon

* feat: remove some blanks in list.razor

* feat: remove some blanks

* fix: default value is outline for icon list

* fix: click to copy for icon list

* feat: add async to load icon list

* feat: update iconlistService

* chore: update icons

* fix: icon load async

* feat: add application icons in IconlistServices

* fix: remove the exist icon from existed catogory if duplicated

* fix: add @key for list items

* fix: revert the change

Co-authored-by: ElderJames <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants