feat(modul: menu) - MenuItem Title

[ElDiddi]

Hi there,

a little PR for the menu modul.

What's new?

• MenuItem - [Property] Title - Allows to set the Title directly as parameter and not only as ChildComponent.

Changes:

• Menu - [Property] Selectable - Angluar implementation adapted.

EN-US Documentation updated.

🤔 This is a ...

• New feature
• Bug fix
• Site / documentation update
• Demo update
• Component style update
• Bundle size optimization
• Performance optimization
• Refactoring
• Code style optimization
• Test Case
• Branch merge
• Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

• Doc is updated
• Demo is updated/provided or not needed
• Changelog is provided or not needed

[codecov-io]

Codecov Report

Merging #787 (edd441d) into master (9f95650) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #787      +/-   ##
=========================================
- Coverage    3.67%   3.67%   -0.01%     
=========================================
  Files         395     395              
  Lines       17463   17471       +8     
=========================================
  Hits          642     642              
- Misses      16821   16829       +8     

Impacted Files	Coverage Δ
components/menu/MenuItem.razor	0.00% <0.00%> (ø)
components/menu/MenuItem.razor.cs	0.00% <0.00%> (ø)
components/menu/SubMenu.razor.cs	0.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f95650...edd441d. Read the comment docs.

[ElderJames]

Hi @ElDiddi , thank you for your active participation!

But I think IgnoreSelectionAfterClick isn't used very often, can we do that when it is only in the dropdown?

[ElDiddi]

Hello James,

that is a good question.

I think that the option is also useful in a normal menu. For example if you open an external web page in a new tab from a menu item. In that case the menu item would be selected even though you are still on the old page.
However, it would make more sense if that property is set per menu item and not globally in the menu. I could quickly adjust that.

[ElderJames]

Yes, you are right. We can also take a look into angular's routerlink implement.

[ElDiddi]

Yes, you are right. We can also take a look into angular's routerlink implement.

I'm sorry the implementation was already there. Menu property Selectable. But the OnClick event does not fire if you clicked on the menu item.

if (!RootMenu.Selectable)
return;

RootMenu.SelectItem(this);

if (OnClick.HasDelegate)
await OnClick.InvokeAsync(args);

I will change it to this

if (OnClick.HasDelegate)
await OnClick.InvokeAsync(args);

if (!RootMenu.Selectable)
return;

RootMenu.SelectItem(this);