fix(module: modal): dom cannot be destroyed when the page changed on DestroyOnClose is false #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
=========================================
- Coverage 3.67% 3.66% -0.01%
=========================================
Files 395 395
Lines 17481 17504 +23
=========================================
Hits 642 642
- Misses 16839 16862 +23
Continue to review full report at Codecov.
|
ElderJames
requested changes
Nov 18, 2020
components/core/JsInterop/interop.ts
Outdated
| @@ -424,6 +424,12 @@ export function enableBodyScroll() { | |||
| removeCls(document.body, "ant-scrolling-effect"); | |||
| } | |||
|
|
|||
| export function destroyAllDialog() { | |||
| console.log(document.querySelectorAll('.ant-modal-root').length); | |||
There was a problem hiding this comment.
please remove this line of console.log
ElderJames
approved these changes
Nov 18, 2020
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
…DestroyOnClose is false (#799) * fix(module: modal): dom cannot be destroyed when the page changed * chore: remove console.log info of debug
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
…DestroyOnClose is false (#799) * fix(module: modal): dom cannot be destroyed when the page changed * chore: remove console.log info of debug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#757
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge