Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modul: affix) code cleaning, doc update #805

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

ElDiddi
Copy link
Contributor

@ElDiddi ElDiddi commented Nov 19, 2020

Code cleaning and updated the documentation to match the implementation.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

Compiler warnings.

馃摑 Changelog

Code cleaning and updated the documentation to match the implementation.

Language Changelog
馃嚭馃嚫 English Code cleaning and updated the documentation to match the implementation.
馃嚚馃嚦 Chinese Code cleaning and updated the documentation to match the implementation.

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #805 (6b7e18a) into master (b993b8e) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #805   +/-   ##
======================================
  Coverage    3.66%   3.66%           
======================================
  Files         395     395           
  Lines       17520   17519    -1     
======================================
  Hits          642     642           
+ Misses      16878   16877    -1     
Impacted Files Coverage 螖
components/affix/Affix.razor 0.00% <酶> (酶)
components/affix/Affix.razor.cs 0.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b993b8e...6b7e18a. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 803c1fb into ant-design-blazor:master Nov 19, 2020
@ElDiddi ElDiddi deleted the affix-codecleaning branch November 19, 2020 08:34
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
Co-authored-by: Lars Diederich <diederich@evodata.de>
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
Co-authored-by: Lars Diederich <diederich@evodata.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants