fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) #809

zxyao145 · 2020-11-19T13:51:04Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	Inspection before use ModalOptions.AfterClose Is it null
🇨🇳 Chinese	使用前检查ModalOptions.AfterClose是否为null

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Changelog is provided or not needed

…lazor#807) If ModalOptions.AfterClose is null, the exception will be thrown: delegate to an instance method cannot have null 'this'

codecov-io · 2020-11-19T13:58:45Z

Codecov Report

Merging #809 (a2f7262) into master (6186e93) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #809      +/-   ##
=========================================
- Coverage    3.66%   3.66%   -0.01%     
=========================================
  Files         395     395              
  Lines       17515   17518       +3     
=========================================
  Hits          642     642              
- Misses      16873   16876       +3

Impacted Files	Coverage Δ
components/modal/ModalContainer.razor	`0.00% <ø> (ø)`
components/modal/config/ModalOptions.cs	`0.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6186e93...a2f7262. Read the comment docs.

ElderJames · 2020-11-19T14:33:06Z

components/modal/config/ModalOptions.cs

@@ -31,6 +31,11 @@ public class ModalOptions

        public Func<Task> AfterClose { get; set; }

+        internal Func<Task> GetAfterClose()


用自动属性或者直接赋值 AfterClose ?? (() => Task.CompletedTask) 性能高一点，不然每次渲染都要执行方法

ElderJames

LGTM

…dalOptions.AfterClose (#807) (#809) * fix(module: modal): throw error when using ModalService (#807) If ModalOptions.AfterClose is null, the exception will be thrown: delegate to an instance method cannot have null 'this' * refactor: use automatic properties for ModalOptions

fix(module: modal): throw error when using ModalService (ant-design-b…

a2f7262

…lazor#807) If ModalOptions.AfterClose is null, the exception will be thrown: delegate to an instance method cannot have null 'this'

pr-triage bot added the PR: unreviewed label Nov 19, 2020

zxyao145 linked an issue Nov 19, 2020 that may be closed by this pull request

ModalService.CreateModal throws error #807

Closed

ElderJames reviewed Nov 19, 2020

View reviewed changes

refactor: use automatic properties for ModalOptions

5e73c4f

zxyao145 force-pushed the issue-807 branch from 053d344 to 5e73c4f Compare November 20, 2020 03:06

ElderJames added this to the 0.5.0 - MILESTONE: December 2020 milestone Nov 20, 2020

ElderJames approved these changes Nov 22, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Nov 22, 2020

ElderJames merged commit 09f88f9 into ant-design-blazor:master Nov 22, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Nov 22, 2020

ElderJames mentioned this pull request Nov 22, 2020

ModalService.CreateModal throws error #807

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) #809

fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) #809

zxyao145 commented Nov 19, 2020

codecov-io commented Nov 19, 2020

ElderJames Nov 19, 2020

ElderJames left a comment

		@@ -31,6 +31,11 @@ public class ModalOptions

		public Func<Task> AfterClose { get; set; }

		internal Func<Task> GetAfterClose()

fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) #809

fix(module: modal): throw error when using ModalService if not set ModalOptions.AfterClose (#807) #809

Conversation

zxyao145 commented Nov 19, 2020

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

codecov-io commented Nov 19, 2020

Codecov Report

ElderJames Nov 19, 2020

Choose a reason for hiding this comment

ElderJames left a comment

Choose a reason for hiding this comment