-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PoC(module: iconservice) - Direct loading without HttpWebClient #810
Conversation
/preview |
how is the Icon store generated, Can it be automated? |
Hey @Epictek, i have written a small external C# application which scans the icon folders and generates the class code. It would be conceivable to write a small command line application that is executed before the build process starts, which then creates the class file. |
We should generate icons form ant-design. How about using Github Action like ours styles-sync-bot? |
Hey @Epictek , what do you think of this PR? |
Think we need the script used to generate the class before merging. I also made something similar a while ago but with Razor files and was a very much WIP |
If we decide to embed it in the assembly, then I think we can directly generate the icon components as the same to ant-design react. e.g. |
Sounds good to me :)
‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
…On Saturday, December 5, 2020 1:50 PM, James Yeung ***@***.***> wrote:
If we decide to embed it in the assembly, then I think we can directly generate the icon components as the same to ant-design react.
e.g. <UserOutlined />
—
You are receiving this because you were mentioned.
Reply to this email directly, [view it on GitHub](#810 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AALF7HVOCVKCX3DTLKGO5B3STI3AXANCNFSM4T3QIPIA).
|
Co-authored-by: Lars Diederich <diederich@evodata.de> Co-authored-by: James Yeung <shunjiey@hotmail.com>
Co-authored-by: Lars Diederich <diederich@evodata.de> Co-authored-by: James Yeung <shunjiey@hotmail.com>
It is only a little PoC of how to customise the IconService so that the icons can be loaded directly and without HttpWebClient.
Therefore I created a new static class, in which the icons are listed.
As @Epictek has already written, the compressed assembly will be 160-200kb larger.
This covers following issues:
#772
#668