Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC(module: iconservice) - Direct loading without HttpWebClient #810

Merged
merged 2 commits into from
Dec 8, 2020

Conversation

ElDiddi
Copy link
Contributor

@ElDiddi ElDiddi commented Nov 19, 2020

It is only a little PoC of how to customise the IconService so that the icons can be loaded directly and without HttpWebClient.

Therefore I created a new static class, in which the icons are listed.

As @Epictek has already written, the compressed assembly will be 160-200kb larger.

This covers following issues:
#772
#668

@ElDiddi ElDiddi changed the title PoC(module: iconservice) - Directloading without HttpWebClient PoC(module: iconservice) - Direct loading without HttpWebClient Nov 19, 2020
@ElDiddi
Copy link
Contributor Author

ElDiddi commented Nov 19, 2020

/preview

@github-actions
Copy link

github-actions bot commented Nov 19, 2020

@Epictek
Copy link
Member

Epictek commented Nov 19, 2020

how is the Icon store generated, Can it be automated?

@ElDiddi
Copy link
Contributor Author

ElDiddi commented Nov 19, 2020

Hey @Epictek,

i have written a small external C# application which scans the icon folders and generates the class code. It would be conceivable to write a small command line application that is executed before the build process starts, which then creates the class file.

@ElderJames
Copy link
Member

We should generate icons form ant-design. How about using Github Action like ours styles-sync-bot?

@ElderJames
Copy link
Member

Hey @Epictek , what do you think of this PR?

@Epictek
Copy link
Member

Epictek commented Dec 5, 2020

Think we need the script used to generate the class before merging.

I also made something similar a while ago but with Razor files and was a very much WIP

https://www.github.com/Epictek/ant-design-icons/tree/blazor/packages%2Ficons-blazor%2Fscripts%2Fgenerate.ts

@ElderJames
Copy link
Member

If we decide to embed it in the assembly, then I think we can directly generate the icon components as the same to ant-design react.

e.g. <UserOutlined />

@Epictek
Copy link
Member

Epictek commented Dec 6, 2020 via email

@ElderJames ElderJames merged commit 723139f into ant-design-blazor:master Dec 8, 2020
ElderJames added a commit that referenced this pull request Apr 23, 2022
Co-authored-by: Lars Diederich <diederich@evodata.de>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
Co-authored-by: Lars Diederich <diederich@evodata.de>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IconService is using address from Base tag to retrieve icons.json file Improve perfomance of loading icons
4 participants