Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(module: input-number): support all numeric types #850

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

Zonciu
Copy link
Member

@Zonciu Zonciu commented Dec 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English support all numeric types
🇨🇳 Chinese 支持全部数字类型

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #850 (a285dc9) into master (2a3d171) will increase coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #850      +/-   ##
=========================================
+ Coverage    3.81%   3.94%   +0.12%     
=========================================
  Files         399     399              
  Lines       17815   17990     +175     
=========================================
+ Hits          680     709      +29     
- Misses      17135   17281     +146     
Impacted Files Coverage Δ
components/input-number/InputNumber.razor.cs 0.00% <0.00%> (ø)
components/input-number/InputNumberMath.cs 0.00% <0.00%> (ø)
components/core/Base/AntComponentBase.cs 42.30% <0.00%> (+1.28%) ⬆️
components/tabs/Tabs.razor.cs 56.32% <0.00%> (+11.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a3d171...a285dc9. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants