Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sider togglecollapse #879

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Expose sider togglecollapse #879

merged 1 commit into from
Dec 11, 2020

Conversation

Hona
Copy link
Member

@Hona Hona commented Dec 11, 2020

馃 This is a...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • [ x ] Other (about what?)

API Change

馃敆 Related issue link

I want to be able to toggle the collapsing of the sider with some code, so this API needs to be exposed

馃挕 Background and solution

Exposing the API to toggle should be sufficient

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • [ x ] Doc is updated/provided or not needed
  • [ x ] Demo is updated/provided or not needed
  • [ x ] Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #879 (e2e7420) into master (e011db5) will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #879      +/-   ##
=========================================
+ Coverage    5.40%   5.56%   +0.15%     
=========================================
  Files         400     400              
  Lines       21282   21282              
=========================================
+ Hits         1150    1184      +34     
+ Misses      20132   20098      -34     
Impacted Files Coverage 螖
components/layout/Sider.razor.cs 0.00% <酶> (酶)
components/tabs/TabPane.razor.cs 92.06% <0.00%> (+1.58%) 猬嗭笍
components/core/Base/AntComponentBase.cs 42.30% <0.00%> (+5.12%) 猬嗭笍
components/tabs/Tabs.razor.cs 56.32% <0.00%> (+11.83%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e011db5...e2e7420. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants