Make description element visible if passed in ChildContent #881

szmalec · 2020-12-11T12:55:12Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

Fix is simple - modified conditions which are used to apply ant-alert-description to span with desciption (span was rendered but with default display: none style).
One thing to mention - the user can simultaneously pass the value in the Description parameter and define the content in ChildContent. In this case, two span tags with a description are inserted and render side by side instead of one below the other. I did not try to fix this because it is a rather rare case and I also feel average about CSS;]

📝 Changelog

Language	Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Changelog is provided or not needed

…ldContent (ant-design-blazor#875)

…ter ChildContent is used (ant-design-blazor#875)

codecov-io · 2020-12-11T13:12:34Z

Codecov Report

Merging #881 (4fa0258) into master (c9ec05e) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #881      +/-   ##
=========================================
+ Coverage    5.40%   5.55%   +0.15%     
=========================================
  Files         400     400              
  Lines       21282   21282              
=========================================
+ Hits         1150    1182      +32     
+ Misses      20132   20100      -32

Impacted Files	Coverage Δ
components/alert/Alert.razor.cs	`0.00% <0.00%> (ø)`
components/tabs/TabPane.razor.cs	`92.06% <0.00%> (+1.58%)`	⬆️
components/core/Base/AntComponentBase.cs	`42.30% <0.00%> (+5.12%)`	⬆️
components/tabs/Tabs.razor.cs	`55.51% <0.00%> (+11.02%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ec05e...4fa0258. Read the comment docs.

ElderJames

LGTM

…ldContent (#881) * fix(module: alert): make description element visible if passed in ChildContent (#875) * docs(module: alert): modified example - instead of Description parameter ChildContent is used (#875)

szmalec added 2 commits December 11, 2020 13:43

fix(module: alert): make description element visible if passed in Chi…

f337d3b

…ldContent (ant-design-blazor#875)

docs(module: alert): modified example - instead of Description parame…

4fa0258

…ter ChildContent is used (ant-design-blazor#875)

pr-triage bot added the PR: unreviewed label Dec 11, 2020

ElderJames approved these changes Dec 12, 2020

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Dec 12, 2020

ElderJames merged commit 443de9f into ant-design-blazor:master Dec 12, 2020

pr-triage bot added PR: merged and removed PR: reviewed-approved labels Dec 12, 2020

ElderJames added this to the 0.5.0 - MILESTONE: December 2020 milestone Dec 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make description element visible if passed in ChildContent #881

Make description element visible if passed in ChildContent #881

szmalec commented Dec 11, 2020

codecov-io commented Dec 11, 2020

ElderJames left a comment

Make description element visible if passed in ChildContent #881

Make description element visible if passed in ChildContent #881

Conversation

szmalec commented Dec 11, 2020

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

codecov-io commented Dec 11, 2020

Codecov Report

ElderJames left a comment

Choose a reason for hiding this comment