Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using ConfimRef to close Confirm dialog but not reset body's scroll bar (#883) #884

Merged
merged 1 commit into from
Dec 24, 2020

Conversation

zxyao145
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#883

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: using ConfimRef to close Confirm dialog but not reset body's scroll bar
🇨🇳 Chinese 修复使用 ConfimRef 关闭 Confirm 对话框时无法重置 body 滚动条的问题

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #884 (683aa6d) into master (e011db5) will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #884      +/-   ##
=========================================
+ Coverage    5.40%   5.56%   +0.15%     
=========================================
  Files         400     400              
  Lines       21282   21283       +1     
=========================================
+ Hits         1150    1184      +34     
+ Misses      20132   20099      -33     
Impacted Files Coverage Δ
components/modal/ComfirmContainer.razor.cs 0.00% <0.00%> (ø)
components/tabs/TabPane.razor.cs 92.06% <0.00%> (+1.58%) ⬆️
components/core/Base/AntComponentBase.cs 42.30% <0.00%> (+5.12%) ⬆️
components/tabs/Tabs.razor.cs 56.32% <0.00%> (+11.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e011db5...683aa6d. Read the comment docs.

@ElderJames ElderJames merged commit ef711aa into ant-design-blazor:master Dec 24, 2020
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot reset the scroll bar of the body when turn off Confirm dialog with ConfirmRef
3 participants