Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: modal): the Title property is default to string.Empty in … #887

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

ElderJames
Copy link
Member

…ModalOptions

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

Codecov Report

Merging #887 (2897ea2) into master (48511c8) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #887      +/-   ##
=========================================
- Coverage    5.57%   5.56%   -0.02%     
=========================================
  Files         400     400              
  Lines       21190   21282      +92     
=========================================
+ Hits         1182    1184       +2     
- Misses      20008   20098      +90     
Impacted Files Coverage Δ
components/modal/config/ModalOptions.cs 0.00% <0.00%> (ø)
components/slider/Slider.razor.cs 0.00% <0.00%> (ø)
components/tabs/Tabs.razor.cs 56.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48511c8...2897ea2. Read the comment docs.

@ElderJames ElderJames merged commit 21ddb9e into master Dec 14, 2020
@ElderJames ElderJames deleted the fix/modal-title-default-empty branch December 14, 2020 04:54
ElderJames added a commit that referenced this pull request Apr 23, 2022
ElderJames added a commit that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants