Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:OverlayTrigger): overlay will reposition on window resize #897

Merged

Conversation

anddrzejb
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Fixes #895

💡 Background and solution

Added to OverlayTrigger window resize event handler, which is going to repositon the overlay if it is visible while resizing window.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

codecov-io commented Dec 22, 2020

Codecov Report

Merging #897 (815eb7d) into master (8763fda) will increase coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #897   +/-   ##
======================================
  Coverage    5.53%   5.54%           
======================================
  Files         401     401           
  Lines       21337   21344    +7     
======================================
+ Hits         1182    1183    +1     
- Misses      20155   20161    +6     
Impacted Files Coverage Δ
...nts/core/Component/overlay/OverlayTrigger.razor.cs 9.09% <14.28%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8763fda...815eb7d. Read the comment docs.

@anddrzejb
Copy link
Member Author

@mutouzdl what is going on in here? Why this gets unreviewed by pr-triage?

@ElderJames ElderJames merged commit 1ef3425 into ant-design-blazor:master Dec 24, 2020
@anddrzejb anddrzejb deleted the overlayRepositionOnResize branch December 24, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any component that relies on Overlay does not respond to window resizing
4 participants