Implement optional key debouncing #899
Conversation
|
Thank you for contribution @Hona I think we could also add another flag to change value on blur. |
|
@ElderJames Do you mean forcing the update without the debounce? If so then it should be done in the last commit |
|
Yes, that can preserves the behavior of the build-in InputText component. It listen the blur event instead input or keyup. |
|
Hi @Hona ,I have test the last commit, and it also would stuck at change value sometime. So I think we can only change value with blur event when |
Codecov Report
@@ Coverage Diff @@
## master #899 +/- ##
=========================================
+ Coverage 5.40% 5.55% +0.15%
=========================================
Files 400 400
Lines 21282 21301 +19
=========================================
+ Hits 1150 1184 +34
+ Misses 20132 20117 -15
Continue to review full report at Codecov.
|
* Implement optional key debouncing * Fixes & refactor * Force update value on blur * Only change value on blur if debounce is disabled * fix: default to enable debounce and change value on blur directly Co-authored-by: Luke Parker <10430890+TheRealHona@users.noreply.github.com> Co-authored-by: ElderJames <shunjiey@hotmail.com>
* Implement optional key debouncing * Fixes & refactor * Force update value on blur * Only change value on blur if debounce is disabled * fix: default to enable debounce and change value on blur directly Co-authored-by: Luke Parker <10430890+TheRealHona@users.noreply.github.com> Co-authored-by: ElderJames <shunjiey@hotmail.com>
Closes #579
Code based on source from @Magehernan
If the parameter is not set, then there is no behaviour change, once the debounce milliseconds is set, then this will activate the changes.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge