-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:slider): drag, select, focus and rapid reposition fix #903
fix(module:slider): drag, select, focus and rapid reposition fix #903
Conversation
remove unnecessary check from OnMouseMove change position calculation - remove handle size
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
=========================================
- Coverage 5.55% 5.54% -0.02%
=========================================
Files 400 400
Lines 21300 21331 +31
=========================================
- Hits 1184 1182 -2
- Misses 20116 20149 +33
Continue to review full report at Codecov.
|
Thank you @anddrzejb for the great contribution. |
So I see 1 option then: hard code it in the slider div in the |
@anddrzejb It's OK. |
* fix(module:slider): drag lag and reposition fix remove unnecessary check from OnMouseMove change position calculation - remove handle size * fix(module:slider): text select issue while slider drag fix * fix: remove the style * clean value * fix(module:slider): text select while slider drag fix Co-authored-by: ElderJames <shunjiey@hotmail.com>
* fix(module:slider): drag lag and reposition fix remove unnecessary check from OnMouseMove change position calculation - remove handle size * fix(module:slider): text select issue while slider drag fix * fix: remove the style * clean value * fix(module:slider): text select while slider drag fix Co-authored-by: ElderJames <shunjiey@hotmail.com>
🤔 This is a ...
🔗 Related issue link
This addresses a number of small issues with slider:
When clicked and dragged to the left, often before first movement to the left a movement to the right was executed:
When dragging, especially after page load, nothing was happening:
For ranged slider, when dragging one edge beyond the other range, the focus was not following (I am referring to transparent gradient border that is showing when edge gets focus) :
For ranged slider, when quickly dragging one edge beyond the other edge, the "not changed" edge also moves:
When dragging an edge, text selection should be inactive:
💡 Background and solution
IsMoveInEdgeBoundary
was removed fromOnMouseMove
event handler.@{slider-prefix-cls}
cssuser-select:none
📝 Changelog
☑️ Self Check before Merge