Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add locale for Modal and Confirm #932

Merged
merged 7 commits into from
Dec 29, 2020

Conversation

zxyao145
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#928

💡 Background and solution

📝 Changelog

Baidu translation is mainly used for the localization of confirm, and Google translation is used for Mongolian.

Language Changelog
🇺🇸 English add locale for Modal and Confirm
🇨🇳 Chinese 为 Modal 和 Confirm 添加本地化设计

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@zxyao145 zxyao145 linked an issue Dec 27, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Dec 27, 2020

Codecov Report

Merging #932 (c3534a2) into master (e39da99) will increase coverage by 0.13%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #932      +/-   ##
=========================================
+ Coverage    5.43%   5.57%   +0.13%     
=========================================
  Files         404     405       +1     
  Lines       21270   21252      -18     
=========================================
+ Hits         1157    1184      +27     
+ Misses      20113   20068      -45     
Impacted Files Coverage Δ
components/locale-provider/Locale.cs 0.00% <0.00%> (ø)
components/modal/config/ButtonProps.cs 0.00% <0.00%> (ø)
components/modal/config/ConfirmOptions.cs 0.00% <0.00%> (ø)
components/modal/confirmDialog/Confirm.razor 0.00% <0.00%> (ø)
components/modal/confirmDialog/Confirm.razor.cs 0.00% <ø> (ø)
components/modal/confirmDialog/ConfirmLocale.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/Modal.razor.cs 0.00% <0.00%> (ø)
components/modal/modalDialog/ModalLocale.cs 0.00% <ø> (ø)
components/core/Base/AntComponentBase.cs 42.30% <0.00%> (+1.28%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39da99...3a3e10c. Read the comment docs.

@ElderJames ElderJames merged commit fd59009 into ant-design-blazor:master Dec 29, 2020
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* feat(module: modal): add Modal locale

* feat(module: confirm): locale support for zh-cn, en-us

* docs: add the demo of override locale's custom text

* feat: locale's json files add confirm configuration

* fix: custom ButtonProps override Button[1,2,3]Text or OK(Cancel)Text

* docs: using InvokeAsync to invoke StateHasChanged

* docs(module: modal): add override locale de
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* feat(module: modal): add Modal locale

* feat(module: confirm): locale support for zh-cn, en-us

* docs: add the demo of override locale's custom text

* feat: locale's json files add confirm configuration

* fix: custom ButtonProps override Button[1,2,3]Text or OK(Cancel)Text

* docs: using InvokeAsync to invoke StateHasChanged

* docs(module: modal): add override locale de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Modal]ok和cancel按钮无法显示中文
3 participants