Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemMeta component should support a ReactNode format #959

Merged
merged 2 commits into from
Jan 10, 2021
Merged

ListItemMeta component should support a ReactNode format #959

merged 2 commits into from
Jan 10, 2021

Conversation

yanb1
Copy link
Contributor

@yanb1 yanb1 commented Jan 10, 2021

🤔 This is a ...

  • [ X ] Bug fix

Describe the bug

The documentation in the demo specify that ListItemMeta have a description property that should support a ReactNode via the DescriptionTemplate property. Like Avatar and Title properties.
see: https://antblazor.com/en-US/components/list#API

Steps to reproduce (please include code)

Avatar Title Description

Exceptions (if any)

None.

@codecov-io
Copy link

Codecov Report

Merging #959 (3a35cc0) into master (757dafc) will decrease coverage by 0.12%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #959      +/-   ##
=========================================
- Coverage    5.75%   5.62%   -0.13%     
=========================================
  Files         406     406              
  Lines       21723   21729       +6     
=========================================
- Hits         1250    1223      -27     
- Misses      20473   20506      +33     
Impacted Files Coverage Δ
components/list/ListItemMeta.razor 0.00% <0.00%> (ø)
components/list/ListItemMeta.razor.cs 0.00% <0.00%> (ø)
components/tabs/Tabs.razor.cs 44.89% <0.00%> (-10.62%) ⬇️
components/core/Base/AntComponentBase.cs 41.02% <0.00%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 757dafc...3a35cc0. Read the comment docs.

Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ElderJames ElderJames merged commit 9484852 into ant-design-blazor:master Jan 10, 2021
@ElderJames ElderJames linked an issue Jan 10, 2021 that may be closed by this pull request
ElderJames pushed a commit that referenced this pull request Apr 23, 2022
* Added DescriptionTemplate

* Added support for DescriptionTemplate property.
ElderJames pushed a commit that referenced this pull request Apr 30, 2022
* Added DescriptionTemplate

* Added support for DescriptionTemplate property.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListItemMeta component should support a ReactNode format
3 participants