Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: date-picker): prevent the year out of range #973

Merged
merged 6 commits into from
Jan 14, 2021

Conversation

ElderJames
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #973 (26aaf17) into master (aa04950) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #973      +/-   ##
=========================================
- Coverage    5.75%   5.73%   -0.03%     
=========================================
  Files         406     406              
  Lines       21737   21815      +78     
=========================================
- Hits         1252    1250       -2     
- Misses      20485   20565      +80     
Impacted Files Coverage Δ
components/core/Helpers/DateHelper.cs 0.00% <0.00%> (ø)
...nts/date-picker/internal/DatePickerDatePanel.razor 0.00% <0.00%> (ø)
...date-picker/internal/DatePickerDatetimePanel.razor 0.00% <0.00%> (ø)
...s/date-picker/internal/DatePickerDecadePanel.razor 0.00% <0.00%> (ø)
...onents/date-picker/internal/DatePickerHeader.razor 0.00% <0.00%> (ø)
...ts/date-picker/internal/DatePickerMonthPanel.razor 0.00% <0.00%> (ø)
...onents/date-picker/internal/DatePickerPanelBase.cs 0.00% <0.00%> (ø)
.../date-picker/internal/DatePickerQuarterPanel.razor 0.00% <0.00%> (ø)
...ents/date-picker/internal/DatePickerTemplate.razor 0.00% <0.00%> (ø)
...s/date-picker/internal/DatePickerTemplate.razor.cs 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa04950...26aaf17. Read the comment docs.

@anddrzejb
Copy link
Member

@ElderJames Once I finish with what I am doing now and with my plans towards Slider & Tooltip, I was thinking to actually prep unit tests for both Slider and DatePicker/RangePicker, so maybe we can get as much mistakes caught as possible automatically. Sorry for the missed bugs...

@ElderJames
Copy link
Member Author

@anddrzejb That's very nice! We need to do more work in favor of robustness.

@ElderJames ElderJames merged commit 81d6603 into master Jan 14, 2021
@ElderJames ElderJames deleted the fix/datepicker-year-out-range branch January 14, 2021 02:40
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: date-picker): year would out of range

* prevent out of range

* add two methods

* fix(module: datepicker): out of range error

* fix: decadePanel is still out of range

Co-authored-by: 钟迪龙 <musicvs@163.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: date-picker): year would out of range

* prevent out of range

* add two methods

* fix(module: datepicker): out of range error

* fix: decadePanel is still out of range

Co-authored-by: 钟迪龙 <musicvs@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DatePicker - The date of the threshold value directly results in an exception. Such as: the 0001-01-01
4 participants