Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/tabs #26

Merged
merged 12 commits into from
Apr 1, 2022
Merged

Feat/tabs #26

merged 12 commits into from
Apr 1, 2022

Conversation

Simplyme0823
Copy link
Contributor

修复 adjust-content 在基础库 1.x 下的问题

  • 2.x 下内部采用 swiper 基础组件
  • 1.x 下内部采用 view + transform 实现一个简版的”swiper“
  • 由于 swiper 基础组件与 view + transform 的方案，使得用户在 Tabs 内使用 Modal 这类组件时，蒙层被压住，无法覆盖整屏。因此，提供 fallback api，让用户自己去实现这类”swiper“。

bytemain
bytemain approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@bytemain bytemain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Simplyme0823 Simplyme0823 merged commit 69002c9 into master Apr 1, 2022
@Simplyme0823 Simplyme0823 deleted the feat/tabs branch April 1, 2022 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bytemain bytemain bytemain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Simplyme0823 @bytemain