Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable modal button before press handler promise becomes to resolve state #1252

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

fix: disable modal button before press handler promise becomes to resolve state #1252

wants to merge 6 commits into from

Commits on Aug 25, 2022

  1. fix: fix typo variable name from 'orginPress' to 'originPress'

    @cw1997
    cw1997 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d7f2917 View commit details
    Browse the repository at this point in the history

  2. fix: add 'disabled' style to button's style list

    @cw1997
    cw1997 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    55026cb View commit details
    Browse the repository at this point in the history

  3. fix: disable modal ok button before press handler promise becomes to … 

    …resolve state
    @cw1997
    cw1997 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    d7a97d1 View commit details
    Browse the repository at this point in the history

  4. fix: fix type checking logic

    @cw1997
    cw1997 committed Aug 25, 2022
    Configuration menu
    Copy the full SHA
    847fff6 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. fix: use ?? instead of || for setting the default value of origin… 

    …Press
    @cw1997
    cw1997 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    6f7837b View commit details
    Browse the repository at this point in the history

  2. fix: catch the error from originPress(), in finally, restore the butt… 

    …on.style and call this.onClose()
    @cw1997
    cw1997 committed Aug 27, 2022
    Configuration menu
    Copy the full SHA
    a431014 View commit details
    Browse the repository at this point in the history