Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal android fullscreen design #1499

Closed
cncolder opened this issue Jun 28, 2017 · 3 comments
Closed

Modal android fullscreen design #1499

cncolder opened this issue Jun 28, 2017 · 3 comments

Comments

@cncolder
Copy link
Contributor

cncolder commented Jun 28, 2017

Version

1.4.0

Environment

web android

Reproduction link

https://codepen.io/colder/pen/LLeGaN

Steps to reproduce

<Modal transparent={false} platform='android' />

What is expected?

在 iOS 上是真正全屏的。

What is actually happening?

在 Android 上,padding: .3rem .48rem 而且四周还是白色。


设计稿就是这样的吗?请问是遵从什么标准?

@paranoidjk
Copy link
Contributor

  • 看了下,padding 是为了内容区, Modal 是有 title 的,你看下官方 demo
  • 白色是 Modal 默认的背景色,而内容区被你自定义成灰色了,所以有点丑.... 你要自定义样式的时候都自定义就该就好

@cncolder
Copy link
Contributor Author

cncolder commented Jun 28, 2017

@paranoidjk 在 transparent=false 的时候,Modal 没有 title。官方 demo 里露掉了 transparent=false 的例子。

我看了 less,android 样式额外加 padding 去圆角时没有考虑排除 transparent=false 这种情况,应该是 BUG。

iOS 上 transparent=false 时是一个全屏铺满的效果。

@silentcloud
Copy link
Contributor

@cncolder 这个我来修了

lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants