Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast without mask should not follow page scroll #1642

Closed
paranoidjk opened this issue Aug 4, 2017 · 1 comment
Closed

Toast without mask should not follow page scroll #1642

paranoidjk opened this issue Aug 4, 2017 · 1 comment
Assignees
@paranoidjk
Labels
bug

Comments

@paranoidjk
Copy link
Contributor

paranoidjk commented Aug 4, 2017 •
edited

Problem

Right now when display a toast without mask, the user still can touch the page, and toast will follow the page scroll.

https://mobile.ant.design/components/toast-cn#API

  • What's toast without mask actually? right now they looks totally same.
  • If we make toast without mask can not touch the page too, then we can move mask api.

cc @silentcloud @warmhug
@paranoidjk paranoidjk self-assigned this Aug 4, 2017
@paranoidjk
Copy link
Contributor Author

Update:

  • Do not deprecate props.mask.
  • But make toast without mask do not follow page scroll.

@paranoidjk paranoidjk changed the title Toast without mask Toast without mask should not follow page scroll Aug 4, 2017
paranoidjk added a commit that referenced this issue Aug 8, 2017
@paranoidjk
fix(Toast): should not follow page scroll close #1642
c0e43a7
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this issue Apr 26, 2018
@paranoidjk @lixiaoyang1992
fix(Toast): should not follow page scroll close ant-design#1642
a8e3af0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paranoidjk paranoidjk

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paranoidjk