添加搜索框自定义高度 #1113
添加搜索框自定义高度 #1113
Conversation
|
@yezongyang, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pingan1927, @afc163 and @warmhug to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 69.84% 69.86% +0.01%
==========================================
Files 218 218
Lines 4079 4081 +2
Branches 1212 1214 +2
==========================================
+ Hits 2849 2851 +2
Misses 1229 1229
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
RN 这边也统一加下吧，注意 RN 的尺寸是 web 的一半
https://github.com/ant-design/ant-design-mobile/blob/master/components/style/themes/default.tsx#L159
|
@paranoidjk 这个也需要设计师敲定一下的，变量添加需要设计师一起拍 |
|
@silentcloud review RN 那块的样式修改有没有问题，没问题就合掉这个。其他变量的增加后续我来加，设计还没定稿。 |
|
@paranoidjk 代码 ok 的，你再 npm run ios/android 看看，没问题你直接合 |
| @@ -39,7 +39,7 @@ export default StyleSheet.create({ | |||
| tintColor: variables.input_color_icon, | |||
| position: 'absolute', | |||
| left: variables.h_spacing_md + 8, | |||
| top: (variables.search_bar_input_height - variables.icon_size_xxs) / 2 + 8, | |||
| top: (variables.search_bar_height - variables.icon_size_xxs) / 2, | |||
There was a problem hiding this comment.
top: (variables.search_bar_input_height - variables.icon_size_xxs) / 2,
There was a problem hiding this comment.
@yezongyang 你可以按开发文档 跑起来看下，是有问题的
There was a problem hiding this comment.
alignItems 好像对 TextInput 不起作用
|
增加一个组件变量，@search-bar-height |
|
@yezongyang 👍 |
在默认主题中加入搜索框自定义高度