[RN] Optional use TouchableWithoutFeedback component in Flex/FlexItem component #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 18, 2017 20:05
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
+ Coverage 58.1% 58.19% +0.08%
==========================================
Files 253 253
Lines 4399 4437 +38
Branches 1156 1174 +18
==========================================
+ Hits 2556 2582 +26
- Misses 1842 1854 +12
Partials 1 1
Continue to review full report at Codecov.
|
|
+1 |
silentcloud
reviewed
Nov 20, 2017
components/flex/FlexItem.native.tsx
Outdated
| @@ -10,23 +10,42 @@ export interface FlexItemProps extends BasePropsType { | |||
| onPressOut?: any; | |||
| } | |||
|
|
|||
| export default class FlexItem extends React.Component<FlexItemProps, any> { | |||
| export default class FlexItem extends React.Component < FlexItemProps, any > { | |||
silentcloud
reviewed
Nov 20, 2017
components/flex/FlexItem.native.tsx
Outdated
| static defaultProps = { | ||
| flex: 1, | ||
| }; | ||
| render() { | ||
| let { style, children, flex, ...restProps } = this.props; | ||
| let { |
There was a problem hiding this comment.
recommend: no need wrap within 100 columns
|
ping @fengliu222 |
|
@paranoidjk I will fix in few hours. |
|
@paranoidjk Fixed, pls review. |
|
This is not a break change and can be released in next version. |
This was referenced Nov 29, 2017
lixiaoyang1992
pushed a commit
to lixiaoyang1992/ant-design-mobile
that referenced
this pull request
Apr 26, 2018
ant-design#2095) * Enhancement:[RN] Remove TouchableWithoutFeedback wrapper in `flexItem` and `flex` component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relate issues: #1108, #769
FlexandFlexItemnow have capability to switch thatTouchableWithoutFeedbackwrap or not.When developer pass one of
onPressonLongPressonPressInonPressOutparameter, theFlexcomponent will be wrapped byTouchableWithoutFeedback.This solution avoid make a break change to developer.
This change is