Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove body font-size #2106

Merged
merged 1 commit into from Nov 21, 2017
Merged

fix: remove body font-size #2106

merged 1 commit into from Nov 21, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Nov 20, 2017

  • rem 高清方案的用户,引入高清方案脚本来设置 html font size
  • 非高清方案的用户,antd-mobile 设计规范应该对全局的 font-size 没要求

@peter0011

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned paranoidjk Nov 20, 2017
@ghost ghost added the In Progress label Nov 20, 2017
@codecov
Copy link

codecov bot commented Nov 20, 2017

Codecov Report

Merging #2106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2106   +/-   ##
======================================
  Coverage    58.1%   58.1%           
======================================
  Files         253     253           
  Lines        4399    4399           
  Branches     1156    1156           
======================================
  Hits         2556    2556           
  Misses       1842    1842           
  Partials        1       1
Flag Coverage Δ
#rn 60.42% <ø> (ø) ⬆️
#web 56.11% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14413e9...abddbb1. Read the comment docs.

@warmhug warmhug merged commit ec1db93 into master Nov 21, 2017
@warmhug warmhug deleted the remove-body-font-size branch November 21, 2017 07:35
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants