Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nouse style #2145

Merged
merged 1 commit into from Dec 5, 2017
Merged

fix: remove nouse style #2145

merged 1 commit into from Dec 5, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Dec 5, 2017

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #2145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2145   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files         260      260           
  Lines        4463     4463           
  Branches     1179     1179           
=======================================
  Hits         2577     2577           
  Misses       1885     1885           
  Partials        1        1
Flag Coverage Δ
#rn 60.78% <ø> (ø) ⬆️
#web 55.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95596aa...5227985. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 5, 2017

Codecov Report

Merging #2145 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2145   +/-   ##
=======================================
  Coverage   57.74%   57.74%           
=======================================
  Files         260      260           
  Lines        4463     4463           
  Branches     1179     1179           
=======================================
  Hits         2577     2577           
  Misses       1885     1885           
  Partials        1        1
Flag Coverage Δ
#rn 60.78% <ø> (ø) ⬆️
#web 55.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95596aa...5227985. Read the comment docs.

@warmhug warmhug merged commit ff75563 into master Dec 5, 2017
@paranoidjk paranoidjk deleted the fix-list branch December 10, 2017 11:30
lixiaoyang1992 pushed a commit to lixiaoyang1992/ant-design-mobile that referenced this pull request Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants