refactor type definitions #2323

BANG88 · 2018-02-05T08:39:45Z

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

Make sure that you follow antd's code convention.
Run npm run lint and fix those errors before submitting in order to keep consistent code style.
Rebase before creating a PR to keep commit history clear.
Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

Update API docs for the component.
Update/Add demo to demonstrate new feature.
Update TypeScript definition for the component.
Add unit tests for the feature.

Don't merge this is a WIP PR. since it have too many changes. PR here for discussion #2315

This change is

codecov · 2018-02-05T09:25:33Z

Codecov Report

Merging #2323 into master will decrease coverage by 3.85%.
The diff coverage is 55.6%.

@@            Coverage Diff             @@
##           master    #2323      +/-   ##
==========================================
- Coverage   58.74%   54.89%   -3.86%     
==========================================
  Files         259      145     -114     
  Lines        4380     2525    -1855     
  Branches     1157      755     -402     
==========================================
- Hits         2573     1386    -1187     
+ Misses       1806     1134     -672     
- Partials        1        5       +4

Flag	Coverage Δ
#rn	`?`
#web	`54.89% <55.6%> (-2.05%)`	⬇️

Impacted Files	Coverage Δ
components/input-item/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/modal/index.tsx	`100% <ø> (ø)`	⬆️
components/flex/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/menu/SubMenu.tsx	`100% <ø> (ø)`	⬆️
components/calendar/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/menu/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/tab-bar/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/drawer/index.tsx	`100% <ø> (ø)`	⬆️
components/list-view/PropsType.tsx	`0% <ø> (ø)`	⬆️
components/result/PropsType.tsx	`0% <ø> (ø)`	⬆️
... and 182 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29638b9...5db26f3. Read the comment docs.

BANG88 · 2018-03-10T09:54:55Z

Ping @paranoidjk

paranoidjk · 2018-03-12T06:16:01Z

@BANG88 👍 我看看。

加个微信吧，我的 id: paranoidboy 😄

paranoidjk · 2018-03-12T07:14:10Z

components/action-sheet/AndroidContainer.native.tsx

@@ -28,11 +37,19 @@ class ActionSheetAndroid extends React.Component<IActionSheetNativeProps, any> {
      visible: false,
    });
  }
-
+  close = () => {


Looks like we have a bug here?

cc @silentcloud

paranoidjk · 2018-03-12T07:16:47Z

tsconfig.json

@@ -7,6 +7,7 @@
    "noUnusedLocals": true,
    "allowSyntheticDefaultImports":true,
    "target": "es6",
+    "noImplicitAny": true,


So we can close #2147

But i searched the codebase, there still have many any left

Yep. some of them needs enhancement.

paranoidjk · 2018-03-12T07:18:30Z

package.json

@@ -124,68 +123,77 @@
    "webpack-visualizer-plugin": "^0.1.11"
  },
  "scripts": {
-    "lint": "npm run tslint && npm run srclint && npm run demolint && npm run stylelint && npm run applint",
+    "lint":
+      "npm run tslint && npm run srclint && npm run demolint && npm run stylelint && npm run applint",


Why JSON value need to start at newline? looks like is unusual usage.

Miss... formatted automatically by VSCode..

Maybe because its too long for read. 😄

paranoidjk · 2018-03-12T07:28:09Z

components/badge/index.tsx

    });

    return (
      <span className={badgeCls}>
        {children}
-        {(text || dot) && <sup className={scrollNumberCls} {...restProps}>{text}</sup>}
+        {(text || dot) && (
+        // tslint:disable-next-line:jsx-no-multiline-js


Maybe we can disable jsx-no-multiline-js rules, since actually we have lots of usage like this.

Should disable it via ant tools.

I prefer prettier for code formatting.

You can PR to https://github.com/ant-design/antd-tools/blob/master/lib/tslint.json to disable this rule. cc @yesmeck Do you argree to disable this in antd?

Haha, prettier +1

paranoidjk · 2018-03-12T07:38:03Z

components/image-picker/index.tsx

@@ -120,7 +120,9 @@ export default class ImagePicker extends React.Component<
        this.parseFile(files[i], i);
      }
    }
-    fileSelectorEl.value = '';
+    if (fileSelectorEl) {


I have merge #2302.

So that we may not need Defensive programming here.

It maybe null reference so need have a check here.

Since merge #2302 fileSelectorEl should always reference to input element instance once component mount.

Yep but the type of ref are Element | null. TypeScript checker can not pass.

Use fileSelectorEl!.value = '';？Since if null check is a runtime issue. If we only need to let ts compiler skip this, we may use exclamation mark.

I don't like !. may forget check for some reason sometimes

paranoidjk · 2018-03-12T07:42:46Z

components/carousel/__tests__/__snapshots__/demo.test.native.js.snap

@@ -301,7 +300,7 @@ exports[`renders ./components/carousel/demo/basic.native.tsx correctly 1`] = `
                    "justifyContent": "center",
                  },
                  Object {
-                    "backgroundColor": "red",
+                    "backgroundColor": "#ccc",


Why there is several snapshot change in this PR? I think type definition change should not have impact on ui.

Agree. but i forgot why this has been changed. 😢

paranoidjk · 2018-03-12T08:11:57Z

@BANG88 #2339

paranoidjk · 2018-03-15T04:44:11Z

components/icon/index.tsx


-export interface IconPropType {
-  type: string;
+export interface IconProps extends IconPropsType {


继承 SVGAttributes 吧 #2339

paranoidjk · 2018-03-15T04:45:41Z

@BANG88 解决冲突。另外尽量只改类型不改业务逻辑，业务逻辑有问题需要改的的单独 PR。

* master: test: update snapshot ci: upgrade to nodejs 8 fix(Carousel): ant-design#2369 chore: delete upgrade tip fix: Fix all failed test (ant-design#2337) fix: modal.alert content align=center (ant-design#2347) bugfix: fixed bug in image-picker, Uncaught TypeError: Cannot set property 'value' of null (ant-design#2302) # Conflicts: # components/_util/upgradeTip.tsx # components/image-picker/index.tsx

BANG88 · 2018-03-15T06:23:14Z

👌

* refactor(util): noImplicitAny * refactor(accordion): type definitions improvements * refactor(action-sheet): add missing type definitions * chore: configuration * refactor(activity-indicator): type definitions * chore: configuration * refactor(badge): type definitions * refactor(button): type definitions * refactor(calendar): type definitions * refactor(card): type definitions * refactor(carousel): add type definitions and refactor native part * refactor(checkbox): type definitions * refactor(list): type definitions * refactor(date-picker): type definitions * refactor(date-picker-view): type definitions * refactor(drawer): type definitions * refactor(flex): type definitions * refactor(grid): type definitions * refactor(icon): type definitions * refactor(image-picker): type definitions * refactor(input-item): type definitions and code refactor * refactor(locale-provider): type definitions * refactor(menu): type definitions * refactor(modal): type definitions * refactor(nav-bar): type definitions * refactor(notice-bar): type definitions * refactor(pagination): type definitions * refactor(picker): type definitions * refactor(picker-view): type definitions * refactor(popover): type definitions * refactor(progress): type definitions * refactor(radio): type definitions * refactor(range): type definitions * refactor(result): type definitions * refactor(search-bar): type definitions * refactor(segmented-control): type definitions * refactor(slider): type definitions * refactor(stepper): type definitions * refactor(steps): type definitions * refactor(swipe-action): type definitions * refactor(switch): type definitions * refactor(tab-bar): type definitions * refactor(tabs): type definitions * refactor(tag): type definitions * refactor(view|text): type definitions * refactor(textarea-item): type definitions * refactor(toast): type definitions * refactor(white-space): type definitions * refactor(wing-blank): type definitions * refactor(list-view): type definitions * refactor(demo): any * chore(style): use ant-tools tslint configurations * test: update snapshots * chore: remove unnecessary configurations and deps * chore: tslint * chore: add setup file * fix: ant-design#2302 * test: update snap * chore: update deps and fix tests * chore: try to let jest faster * refactor(Icon): extends from SVG Props

BANG88 mentioned this pull request Feb 5, 2018

refactor type definitions #2315

Closed

BANG88 changed the title ~~[WIP] refactor type definitions~~ refactor type definitions Feb 7, 2018

BANG88 added 27 commits March 10, 2018 14:23

refactor(util): noImplicitAny

b756921

refactor(accordion): type definitions improvements

b6b8654

refactor(action-sheet): add missing type definitions

dcab0a3

chore: configuration

d640b3c

refactor(activity-indicator): type definitions

197d3ff

chore: configuration

4cf9297

refactor(badge): type definitions

8b38ab9

refactor(button): type definitions

b1f0b4e

refactor(calendar): type definitions

219a58e

refactor(card): type definitions

e73bc4c

refactor(carousel): add type definitions and refactor native part

84ce950

refactor(checkbox): type definitions

805c850

refactor(list): type definitions

7de1af1

refactor(date-picker): type definitions

789c642

refactor(date-picker-view): type definitions

1f9a473

refactor(drawer): type definitions

ecc9a24

refactor(flex): type definitions

ad386d4

refactor(grid): type definitions

3841dfa

refactor(icon): type definitions

99ce9e0

refactor(image-picker): type definitions

1b7c880

refactor(input-item): type definitions and code refactor

2193adf

refactor(locale-provider): type definitions

97da488

refactor(menu): type definitions

e3c622c

refactor(modal): type definitions

f2776f2

refactor(nav-bar): type definitions

0f9c573

refactor(notice-bar): type definitions

84b248d

refactor(pagination): type definitions

5dac3d7

BANG88 added 3 commits March 10, 2018 14:27

chore: tslint

fd7fd1a

chore: add setup file

2b6f0ae

fix: ant-design#2302

e8d8992

BANG88 force-pushed the refactor-ts branch from e3f792c to e8d8992 Compare March 10, 2018 06:30

BANG88 added 2 commits March 10, 2018 14:37

test: update snap

360cd54

chore: update deps and fix tests

494006a

chore: try to let jest faster

916cf89

paranoidjk reviewed Mar 12, 2018

View reviewed changes

paranoidjk added the refactor label Mar 12, 2018

paranoidjk reviewed Mar 12, 2018

View reviewed changes

paranoidjk mentioned this pull request Mar 12, 2018

Add "color" property to Icon in typescript definition #2339

Closed

9 tasks

ghost assigned BANG88 Mar 13, 2018

ghost added the In Progress label Mar 13, 2018

BANG88 force-pushed the refactor-ts branch from 611df87 to 916cf89 Compare March 13, 2018 01:24

BANG88 requested a review from paranoidjk March 15, 2018 02:29

paranoidjk reviewed Mar 15, 2018

View reviewed changes

BANG88 added 2 commits March 15, 2018 14:17

refactor(Icon): extends from SVG Props

5db26f3

paranoidjk merged commit 77347dd into ant-design:master Mar 16, 2018

paranoidjk mentioned this pull request Mar 19, 2018

fix: input type money #2403

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor type definitions #2323

refactor type definitions #2323

BANG88 commented Feb 5, 2018 •

edited

codecov bot commented Feb 5, 2018 •

edited

BANG88 commented Mar 10, 2018

paranoidjk commented Mar 12, 2018

paranoidjk Mar 12, 2018

paranoidjk Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

yesmeck Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk Mar 12, 2018

BANG88 Mar 12, 2018

paranoidjk commented Mar 12, 2018

paranoidjk Mar 15, 2018

paranoidjk commented Mar 15, 2018

BANG88 commented Mar 15, 2018

refactor type definitions #2323

refactor type definitions #2323

Conversation

BANG88 commented Feb 5, 2018 • edited

codecov bot commented Feb 5, 2018 • edited

Codecov Report

BANG88 commented Mar 10, 2018

paranoidjk commented Mar 12, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

paranoidjk commented Mar 12, 2018

Choose a reason for hiding this comment

paranoidjk commented Mar 15, 2018

BANG88 commented Mar 15, 2018

BANG88 commented Feb 5, 2018 •

edited

codecov bot commented Feb 5, 2018 •

edited