Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert(button): rest props #2404

Merged
merged 1 commit into from Mar 19, 2018

Conversation

BANG88
Copy link
Member

@BANG88 BANG88 commented Mar 19, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned BANG88 Mar 19, 2018
@ghost ghost added the In Progress label Mar 19, 2018
@paranoidjk paranoidjk merged commit 75068bd into ant-design:master Mar 19, 2018
@paranoidjk
Copy link
Contributor

paranoidjk commented Mar 19, 2018

@BANG88 rn 的用例挂了。npm run test:rn, npm run test:rn -- -u etc.

@BANG88
Copy link
Member Author

BANG88 commented Mar 19, 2018

你方便更新一下 snap 吗,我再看 #2381

@paranoidjk
Copy link
Contributor

好。你们厂在用 RN 组件吗?

@BANG88
Copy link
Member Author

BANG88 commented Mar 19, 2018

有配合着用

@paranoidjk
Copy link
Contributor

还不是 snapshot 挂了,是用例挂了 https://travis-ci.org/ant-design/ant-design-mobile/jobs/355279238

@BANG88
Copy link
Member Author

BANG88 commented Mar 19, 2018

好 晚点我看看

@BANG88
Copy link
Member Author

BANG88 commented Mar 19, 2018

@paranoidjk 晕了 这里不需要还原了,现在这个是对的,可以取消MR吗

//  unnecessary see line: 134
    // [
    //   'activeOpacity',
    //   'underlayColor',
    //   'onPress',
    //   'onPressIn',
    //   'onPressOut',
    //   'onShowUnderlay',
    //   'onHideUnderlay',
    // ].forEach(prop => {
    //   if (restProps.hasOwnProperty(prop)) {
    //     delete restProps[prop];
    //   }
    // });

@paranoidjk
Copy link
Contributor

那还是还原原来的代码吧,还是不要依赖顺序的潜规则来保证正确性,不利于长期维护。你新来一个 PR? 我把这个 revert 掉。

@BANG88
Copy link
Member Author

BANG88 commented Mar 20, 2018

ok

@BANG88
Copy link
Member Author

BANG88 commented Mar 20, 2018

不还原也可以 我取消注释的就好了。

BANG88 added a commit to BANG88/ant-design-mobile that referenced this pull request Mar 20, 2018
warmhug pushed a commit that referenced this pull request May 11, 2018
* revert(button): rest props (#2404)

* fix: type definitions #2398

* chore: revert button

* fix: type definitions

* fix: miss

* refactor: revert button
warmhug pushed a commit that referenced this pull request May 15, 2018
* revert(button): rest props (#2404)

* feat: add focus method #2381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants