New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert(button): rest props #2404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@BANG88 rn 的用例挂了。 |
你方便更新一下 snap 吗,我再看 #2381 |
好。你们厂在用 RN 组件吗? |
有配合着用 |
还不是 snapshot 挂了,是用例挂了 https://travis-ci.org/ant-design/ant-design-mobile/jobs/355279238 |
好 晚点我看看 |
@paranoidjk 晕了 这里不需要还原了,现在这个是对的,可以取消MR吗 // unnecessary see line: 134
// [
// 'activeOpacity',
// 'underlayColor',
// 'onPress',
// 'onPressIn',
// 'onPressOut',
// 'onShowUnderlay',
// 'onHideUnderlay',
// ].forEach(prop => {
// if (restProps.hasOwnProperty(prop)) {
// delete restProps[prop];
// }
// }); |
那还是还原原来的代码吧,还是不要依赖顺序的潜规则来保证正确性,不利于长期维护。你新来一个 PR? 我把这个 revert 掉。 |
ok |
不还原也可以 我取消注释的就好了。 |
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
Mar 20, 2018
warmhug
pushed a commit
that referenced
this pull request
May 11, 2018
warmhug
pushed a commit
that referenced
this pull request
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
This change is