Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Picker && SearchBar LocalProvider Context #2511

Merged
merged 2 commits into from May 18, 2018

Conversation

ziluo
Copy link
Contributor

@ziluo ziluo commented May 4, 2018

Refs: #2502

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

This change is Reviewable

@ghost ghost assigned ziluo May 4, 2018
@ghost ghost added the In Progress label May 4, 2018
@ziluo ziluo assigned doxiaodong and unassigned ziluo May 4, 2018
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #2511 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2511      +/-   ##
==========================================
+ Coverage    58.4%   58.42%   +0.02%     
==========================================
  Files         262      262              
  Lines        4565     4599      +34     
  Branches     1289     1306      +17     
==========================================
+ Hits         2666     2687      +21     
- Misses       1894     1907      +13     
  Partials        5        5
Flag Coverage Δ
#rn 60.29% <ø> (ø) ⬆️
#web 56.82% <100%> (+0.06%) ⬆️
Impacted Files Coverage Δ
components/picker/index.tsx 100% <100%> (ø) ⬆️
components/search-bar/index.tsx 80.58% <100%> (+0.19%) ⬆️
components/textarea-item/index.tsx 49.2% <0%> (+3.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11560c...4e94f8a. Read the comment docs.

@ghost ghost assigned ziluo May 4, 2018
@paranoidjk
Copy link
Contributor

2018-05-04 18 04 52
这个要处理好,项目下 git config 先设置好,然后 git commit --amend --reset-author 或者 git rebase -i 都可以有办法改过来

@warmhug warmhug requested a review from paranoidjk May 4, 2018 10:36
@warmhug
Copy link
Contributor

warmhug commented May 15, 2018

Is this ok now ??

@ziluo ziluo merged commit 42f07a9 into master May 18, 2018
@warmhug warmhug deleted the fix/locale-provider-context branch May 18, 2018 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants