Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input-item): add "onVirtualKeyboardConfirm" callback #2551

Merged
merged 2 commits into from May 19, 2018

Conversation

micooz
Copy link
Contributor

@micooz micooz commented May 19, 2018

This commit add a new property that allow user to handle virtual
keyboard confirm event.

Closes: #2192, #2249

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned micooz May 19, 2018
@ghost ghost added the In Progress label May 19, 2018
@micooz micooz requested a review from KgTong May 19, 2018 08:02
@@ -35,6 +35,7 @@ Properties | Descrition | Type | Default
| onErrorClick | callback that is called when the error icon is clicked | (e: Object): void | |
| extra | the right content of `InputItem` | string or node | '' |
| onExtraClick | callback that is called when the extra content is clicked | (e: Object): void | |
| onVirtualKeyboardConfirm | callback that is called when "confirm" button of virtual keyboard is clicked | (e: Object): void | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the value is string not object

This commit add a new property that allow user to handle virtual
keyboard confirm event.

Closes: ant-design#2192, ant-design#2249
@micooz micooz force-pushed the feat/keyboard-confirm-callback branch from 07eea9c to 228671b Compare May 19, 2018 12:18
@KgTong KgTong merged commit 0ac8edd into ant-design:master May 19, 2018
@KgTong KgTong mentioned this pull request May 19, 2018
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputItem type类型为money时唤起数字键盘 缺少确认按钮监听事件
2 participants