Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix jest test error #2657

Merged
merged 1 commit into from
Jun 20, 2018
Merged

test: fix jest test error #2657

merged 1 commit into from
Jun 20, 2018

Conversation

ziluo
Copy link
Contributor

@ziluo ziluo commented Jun 20, 2018

Update Jest to 23

image

Issue: jestjs/jest#5401

Fix shared demoTest

image

Ref: https://github.com/ant-design/ant-design/blob/master/tests/shared/demoTest.js#L16

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@ghost ghost assigned ziluo Jun 20, 2018
@ghost ghost added the In Progress label Jun 20, 2018
@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@9ae364f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2657   +/-   ##
=========================================
  Coverage          ?   59.24%           
=========================================
  Files             ?       90           
  Lines             ?     2191           
  Branches          ?      626           
=========================================
  Hits              ?     1298           
  Misses            ?      887           
  Partials          ?        6
Flag Coverage Δ
#web 59.24% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ae364f...37cc184. Read the comment docs.

@hotoo hotoo merged commit e0651fa into master Jun 20, 2018
@hotoo hotoo deleted the fixJest branch June 20, 2018 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants