feat: ImagePicker support customized length #2700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## 2.3.x #2700 +/- ##
========================================
Coverage ? 59.31%
========================================
Files ? 92
Lines ? 2205
Branches ? 627
========================================
Hits ? 1308
Misses ? 891
Partials ? 6
Continue to review full report at Codecov.
|
doxiaodong
reviewed
Jul 3, 2018
| | accept| File type accept | string | image/* | | ||
| | multiple | whether support choose multi images at once | boolean | false | | ||
| | accept | File type accept | string | image/* | | ||
| | length | 单行的图片数量 | string | number | 4 | |
There was a problem hiding this comment.
| length | 单行的图片数量 | string \| number | 4 |
|
这个这么短，合成一个 commit 吧 |
ziluo
force-pushed
the
image_picker_support_length
branch
from
58f0ba5
to
e436def
Compare
KgTong
pushed a commit
that referenced
this pull request
Aug 8, 2018
chenKuer
pushed a commit
that referenced
this pull request
Aug 8, 2018
chenKuer
added a commit
that referenced
this pull request
Aug 15, 2018
* Fix: Flex margin when direction=column (#2711) * chore:add 2.2.2 changelog (#2716) * chore:add 2.2.2 changelog * feat: release 2.2.2 * feat:update snapshot (#2717) * docs: correct DatePicker api, ref #2378 * initial * feat: printer * feat: API * add: demo: basic; disable; tabs; * test: add test file * fix: change function style * fix: clear unnecessary code in demo * fix: down component of printer * feat: ImagePicker support customized length (#2700) * PickData label support ReactNode (#2720) * fix: update PickerData PropTypes * fix: picker format proptype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2619 close #2668
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
This change is