Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InputItem): add moneyKeyboardHeader property #2820

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

micooz
Copy link
Contributor

@micooz micooz commented Sep 4, 2018

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@micooz micooz requested a review from KgTong September 4, 2018 10:18
@ghost ghost assigned micooz Sep 4, 2018
@ghost ghost added the In Progress label Sep 4, 2018
@codecov
Copy link

codecov bot commented Sep 4, 2018

Codecov Report

Merging #2820 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2820      +/-   ##
==========================================
- Coverage   59.37%   59.34%   -0.03%     
==========================================
  Files          92       92              
  Lines        2208     2209       +1     
  Branches      628      629       +1     
==========================================
  Hits         1311     1311              
- Misses        891      892       +1     
  Partials        6        6
Flag Coverage Δ
#web 59.34% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
components/input-item/CustomInput.tsx 31.16% <ø> (ø) ⬆️
components/input-item/index.tsx 47.05% <ø> (ø) ⬆️
components/input-item/CustomKeyboard.tsx 4.54% <0%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6134577...2f32fea. Read the comment docs.

@doxiaodong
Copy link
Contributor

@KgTong

@KgTong KgTong closed this Sep 6, 2018
@KgTong KgTong reopened this Sep 6, 2018
@ghost ghost assigned KgTong Sep 6, 2018
@KgTong KgTong merged commit 1ecad9b into ant-design:master Sep 6, 2018
@yipengmu
Copy link

yipengmu commented Sep 6, 2018

mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants