Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix height error on chrome 73 or later #3188

Merged
merged 2 commits into from
Apr 25, 2019
Merged

fix: fix height error on chrome 73 or later #3188

merged 2 commits into from
Apr 25, 2019

Conversation

likezero
Copy link
Contributor

@likezero likezero commented Apr 24, 2019

close #3119
close #3140
First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This change is Reviewable

@ghost ghost assigned likezero Apr 24, 2019
@ghost ghost added the In Progress label Apr 24, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3b4fd9e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3188   +/-   ##
=========================================
  Coverage          ?   60.05%           
=========================================
  Files             ?       92           
  Lines             ?     2278           
  Branches          ?      654           
=========================================
  Hits              ?     1368           
  Misses            ?      901           
  Partials          ?        9
Flag Coverage Δ
#web 60.05% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b4fd9e...d576737. Read the comment docs.

@ziluo ziluo merged commit 4b42932 into master Apr 25, 2019
@ziluo ziluo deleted the fix-bug-chrome73 branch April 25, 2019 01:13
@ziluo
Copy link
Contributor

ziluo commented Apr 25, 2019

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants