feat: Input add onEnterPress and onKeyDown props #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy PR Preview failed. |
awmleer
requested changes
Oct 25, 2021
src/components/input/index.en.md
Outdated
|
|
||
| In addition, the following native attributes are supported: `maxLength` `minLength` `max` `min` `autoComplete` `enterKeyHint` `pattern` `type` `onFocus` `onBlur` `autoCapitalize` `autoCorrect` | ||
| In addition, the following native attributes are supported: `maxLength` `minLength` `max` `min` `autoComplete` `enterKeyHint` `pattern` `type` `onFocus` `onBlur` `autoCapitalize` `autoCorrect` `onKeyDown` |
| @@ -73,6 +75,13 @@ export const Input = forwardRef<InputRef, InputProps>((p, ref) => { | |||
| }, | |||
| })) | |||
|
|
|||
| const handleKeydown = (e: React.KeyboardEvent<HTMLInputElement>) => { | |||
| if (props.onEnterPress && (e.code === 'Enter' || e.keyCode === 13)) { | |||
| props.onEnterPress(e) | |||
There was a problem hiding this comment.
本来在想这里的 onEnterPress 事件是不是应该在 onKeyUp 中触发，后来试了一下发现 Google 的逻辑就是 onKeyDown，也还是挺合理的
src/components/input/index.zh.md
Outdated
| @@ -17,8 +17,9 @@ | |||
| | clearable | 是否启用清除图标，点击清除图标后会清空输入框 | `boolean` | `false` | | |||
| | onClear | 点击清除按钮后触发 | `() => void` | - | | |||
| | id | input 元素的 id，常用来配合 label 使用 | `string` | - | | |||
| | onEnterPress | 按下回车的回调 | `(e) => void` | - | | |||
|
ok～已补充 |
jermyn626
force-pushed
the
feat-input-onEnterPress
branch
from
e4b6a32
to
55a043d
Compare
awmleer
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support #4248