Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: replace useUpdateLayoutEffect with useIsomorphicUpdateLayouEffect #4848

Merged
merged 2 commits into from
Feb 26, 2022

Conversation

miracles1919
Copy link
Contributor

  1. 给 ahooks 提了个 pr,createUpdateEffect 可以直接 import 了

  2. 把所有的 useUpdateLayoutEffect 替换成了 useIsomorphicUpdateLayouEffect

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #4848 (5bb9192) into master (8b03299) will decrease coverage by 0.02%.
The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4848      +/-   ##
==========================================
- Coverage   26.16%   26.13%   -0.03%     
==========================================
  Files         257      257              
  Lines        5458     5475      +17     
  Branches     1264     1272       +8     
==========================================
+ Hits         1428     1431       +3     
- Misses       3778     3784       +6     
- Partials      252      260       +8     
Impacted Files Coverage Δ
src/components/tabs/tabs.tsx 0.00% <0.00%> (ø)
src/utils/use-tab-list-scroll.ts 0.00% <0.00%> (ø)
src/components/collapse/collapse.tsx 88.37% <100.00%> (+0.13%) ⬆️
src/utils/use-isomorphic-update-layout-effect.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/stepper/stepper.tsx 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b03299...5bb9192. Read the comment docs.

@github-actions
Copy link
Contributor

PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-4848.surge.sh

@awmleer
Copy link
Member

awmleer commented Feb 25, 2022

OK,晚些时候再合并,等用户慢慢先升级了 ahooks,不然用户如果只升级 antd-mobile,没有升级 ahooks,会出问题的

@awmleer awmleer self-assigned this Feb 25, 2022
@awmleer awmleer changed the title enchance: replace useUpdateLayoutEffect with useIsomorphicUpdateLayouEffect enhance: replace useUpdateLayoutEffect with useIsomorphicUpdateLayouEffect Feb 25, 2022
@awmleer
Copy link
Member

awmleer commented Feb 26, 2022

我想错了,我们 dependencies 里已经标了 "ahooks": "^3.1.10",那看来不会存在问题的

@awmleer awmleer merged commit 1f7632e into ant-design:master Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants