enhance(NavBar): back support ReactNode #5715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 89.39% // Head: 90.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5715 +/- ##
==========================================
+ Coverage 89.39% 90.02% +0.63%
==========================================
Files 296 297 +1
Lines 6318 6339 +21
Branches 1548 1554 +6
==========================================
+ Hits 5648 5707 +59
+ Misses 620 584 -36
+ Partials 50 48 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-5715.surge.sh |
miracles1919
previously approved these changes
Oct 9, 2022
afc163
reviewed
Oct 10, 2022
src/components/nav-bar/nav-bar.tsx
Outdated
| @@ -7,7 +7,7 @@ import { mergeProps } from '../../utils/with-default-props' | |||
| const classPrefix = `adm-nav-bar` | |||
|
|
|||
| export type NavBarProps = { | |||
| back?: string | null | |||
| back?: ReactNode | null | |||
There was a problem hiding this comment.
Suggested change
| back?: ReactNode | null | |
| back?: ReactNode |
null 也在 ReactNode 里的
afc163
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #5714