fix(ImageUploader): revokeObjectURL while file change #5815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.10% // Head: 90.26% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5815 +/- ##
==========================================
+ Coverage 90.10% 90.26% +0.15%
==========================================
Files 297 297
Lines 6387 6387
Branches 1576 1577 +1
==========================================
+ Hits 5755 5765 +10
+ Misses 580 572 -8
+ Partials 52 50 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-5815.surge.sh |
zqran
previously approved these changes
Nov 18, 2022
zombieJ
reviewed
Nov 24, 2022
| return () => { | ||
| URL.revokeObjectURL(src) | ||
| if (file) URL.revokeObjectURL(src) |
miracles1919
approved these changes
Nov 25, 2022
zombieJ
approved these changes
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5813