feat(CheckList): allow using number as value #6335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1587315093
reviewed
Aug 24, 2023
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6335.surge.sh |
|
CI fail~ |
Updated |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6335 +/- ##
==========================================
- Coverage 91.56% 91.56% -0.01%
==========================================
Files 306 306
Lines 6592 6591 -1
Branches 1627 1626 -1
==========================================
- Hits 6036 6035 -1
Misses 521 521
Partials 35 35
☔ View full report in Codecov by Sentry. |
1587315093
reviewed
Aug 25, 2023
1587315093
approved these changes
Aug 25, 2023
cytle
pushed a commit
to cytle/ant-design-mobile
that referenced
this pull request
Sep 11, 2023
* feat(CheckList): allow using number as value * refactor(CheckList): move value type to component * fix(CascaderView): update CascaderValue type * refactor(CheckList): update type import path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, it is allowed to use only a string as a value in the CheckList, but it is also possible to use numbers.