feat: hard-coded colors to use variables instead #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cytle
commented
Aug 29, 2023
cytle
commented
- 已知写死颜色的组件改为使用 css var
- yellow、orange、wathet 3 个颜色之前主题中为定义，亮/暗主题补充增加了 3 个 css var
- 部分颜色未替换钉钉群中已同步
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6340 +/- ##
==========================================
- Coverage 91.56% 91.56% -0.01%
==========================================
Files 306 306
Lines 6592 6590 -2
Branches 1627 1626 -1
==========================================
- Hits 6036 6034 -2
Misses 521 521
Partials 35 35 ☔ View full report in Codecov by Sentry. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6340.surge.sh |
zombieJ
reviewed
Sep 6, 2023
src/components/badge/index.en.md
Outdated
| @@ -26,6 +26,6 @@ It is suitable for reminders of productized new news, new functions, new service | |||
|
|
|||
| | Name | Description | Default | Global | | |||
| | --- | --- | --- | --- | | |||
| | --color | The background color of the Badge | `#ff411c` | `--adm-badge-color` | | |||
| | --color | The background color of the Badge | `var(--adm-color-danger)` | `--adm-badge-color` | | |||
There was a problem hiding this comment.
这个应该是 --color-highlight，然后 highlight 对应的是 danger~
zombieJ
approved these changes
Sep 6, 2023
cytle
added a commit
to cytle/ant-design-mobile
that referenced
this pull request
Sep 11, 2023
* feat: hard-coded colors to use variables instead * chore: revert color in svg * doc(notice-bar): update default values of css var in the document * feat: add --adm-color-highlight css var to represent highlight color
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.