feat: add maxCount to Popover.Menu #6373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6373.surge.sh |
|
这个看不出来可以滚动... 
|
|
加了个这样的箭头咋样
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feature #6373 +/- ##
===========================================
- Coverage 91.36% 91.33% -0.03%
===========================================
Files 310 310
Lines 6668 6670 +2
Branches 1657 1659 +2
===========================================
Hits 6092 6092
- Misses 540 542 +2
Partials 36 36
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Oct 13, 2023
| @@ -42,9 +43,20 @@ export const PopoverMenu = forwardRef<PopoverRef, PopoverMenuProps>( | |||
| ) | |||
|
|
|||
| const overlay = useMemo(() => { | |||
| const whetherScroll = | |||
| props?.maxCount && props.actions.length > props?.maxCount | |||
| const innerHeight = props?.maxCount && props?.maxCount * 48 | |||
There was a problem hiding this comment.
实不相瞒item 的盒模型是我人工计算出的48
然后应该是这里的结构嵌套问题，然后初次渲染时拿不到dom，通过api获取不了overlay 里 item 的 height
zombieJ
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6360
48 为每个 item 的高度