fix: pass getContainer down to popup #6460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zombieJ
reviewed
Nov 30, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #6460 +/- ##
==========================================
+ Coverage 92.10% 92.28% +0.18%
==========================================
Files 316 316
Lines 6861 6866 +5
Branches 1719 1720 +1
==========================================
+ Hits 6319 6336 +17
+ Misses 504 494 -10
+ Partials 38 36 -2 ☔ View full report in Codecov by Sentry. |
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6460.surge.sh |
zombieJ
approved these changes
Nov 30, 2023
|
Deploy PR preview failed. |
1 similar comment
|
Deploy PR preview failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #6455
it is needed to render the CalendarPicker inside the Shadow DOM