feat: add scrollReverse props, autoplay reverse #6589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR preview has been successfully built and deployed to https://antd-mobile-preview-pr-6589.surge.sh |
zombieJ
reviewed
Apr 8, 2024
src/components/swiper/swiper.tsx
Outdated
| @@ -45,6 +45,7 @@ export type SwiperProps = { | |||
| defaultIndex?: number | |||
| allowTouchMove?: boolean | |||
| autoplay?: boolean | |||
| scrollReverse?: boolean | |||
There was a problem hiding this comment.
感觉可以给 autoplay 加个 reverse:
autoplay?: boolean | 'reverse';
zombieJ
reviewed
Apr 8, 2024
|
|
||
| // trigger once | ||
| act(() => { | ||
| jest.runOnlyPendingTimers() |
There was a problem hiding this comment.
这个默认就是第一个，即便跑了时间，其实还是第一个，这样是测不出来的。需要切换到后面，然后再跑时间
zombieJ
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when I want auto play from right to left or top to bottom, it's useful