Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: lint flow #881

Merged
merged 1 commit into from
Feb 24, 2017
Merged

refactor: lint flow #881

merged 1 commit into from
Feb 24, 2017

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Feb 24, 2017

. ref ant-design/ant-design#4941

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

@paranoidjk paranoidjk changed the title refactor: lint flow. ref ant-design/ant-design#4941 refactor: lint flow Feb 24, 2017
@paranoidjk paranoidjk merged commit e6611bd into master Feb 24, 2017
@paranoidjk paranoidjk deleted the lint-backup branch February 24, 2017 07:12
"{tests,site,scripts,components}/**/*.{js,jsx}": [
"lint-staged:es"
],
"components/**/*.less": "stylelint --syntax less",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

antd-mobile 目前没有用 stylelint。ant-design/ant-design#2179

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 我看能不能加过来吧,越晚加越难改
  • 也许这些东西可以统一收拢为 antd-tool run lint ?

@paranoidjk paranoidjk mentioned this pull request Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants