This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
fix collapsed warning #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -143,7 +143,7 @@ function useCollapsed( | |||
| onCollapse: BasicLayoutProps['onCollapse'], | |||
| ): [boolean | undefined, BasicLayoutProps['onCollapse']] { | |||
| warning( | |||
| collapsed === undefined || onCollapse === undefined, | |||
| (collapsed === undefined) === (onCollapse === undefined), | |||
There was a problem hiding this comment.
不能用&&，最终目的是断言这两个属性需要同时设置，或者同时不设置。异或取反！
afc163
reviewed
Aug 8, 2019
| @@ -143,7 +143,7 @@ function useCollapsed( | |||
| onCollapse: BasicLayoutProps['onCollapse'], | |||
| ): [boolean | undefined, BasicLayoutProps['onCollapse']] { | |||
| warning( | |||
| collapsed === undefined || onCollapse === undefined, | |||
| (collapsed === undefined) === (onCollapse === undefined), | |||
There was a problem hiding this comment.
Suggested change
| (collapsed === undefined) === (onCollapse === undefined), | |
| (collapsed !== undefined && onCollapse !== undefined) || (collapsed === undefined && onCollapse === undefined) |
There was a problem hiding this comment.
两种写法达到的目的是一致的，用===更精简点。
There was a problem hiding this comment.
不一致，两个都不为 undefined 时也不应该 warning。
There was a problem hiding this comment.
两个都不为undefined的时候，两边都是false，false===false，结果是true，所以不会warning。
There was a problem hiding this comment.
用位运算表示 这是一个 <同或> 的问题
| a | b | a⊙b |
|---|---|---|
| 0 | 0 | 1 |
| 1 | 1 | 1 |
| 0 | 1 | 0 |
| 1 | 0 | 0 |
There was a problem hiding this comment.
(collapsed !== undefined && onCollapse !== undefined) || (collapsed === undefined && onCollapse === undefined)
这种写法更易读
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix set onCollapse and collapsed warning
before
after