feature: Ellipsis components add "caculateShowLength" #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design-pro ready! Built with commit bde38b2 |
afc163
reviewed
Jun 8, 2018
src/components/Ellipsis/index.d.ts
Outdated
| @@ -5,6 +5,7 @@ export interface IEllipsisProps { | |||
| lines?: number; | |||
| style?: React.CSSProperties; | |||
| className?: string; | |||
| caculateShowLength?: boolean; | |||
There was a problem hiding this comment.
yes, I can't get a more proper name.
There was a problem hiding this comment.
这个api是用来控制计算长度是是否将全角字符的长度视为2， 改成whetherCaculateShowLength?感觉太长了。
There was a problem hiding this comment.
或者改成enableFullWidth？
There was a problem hiding this comment.
fullWidthRecognition 如何？
|
要不要搞个测试？ |
|
关键的两个函数的测试写了，感觉没必要加组件测试 |
|
ok！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whether consider full-width character length as 2 when calculate string length. #1635