Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove repetitive icons #587

Merged
merged 1 commit into from
Feb 27, 2024
Merged

fix: remove repetitive icons #587

merged 1 commit into from
Feb 27, 2024

Conversation

yutingzhao1991
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Feb 26, 2024

⚠️ No Changeset found

Latest commit: afc354f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ant-design-web3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2024 9:48am

Copy link

github-actions bot commented Feb 26, 2024

@yutingzhao1991
Copy link
Collaborator Author

@LCJove 发现你加的哪些 icon 有一些是之前就有的

@kiner-tang
Copy link
Member

是不是也加一个 changelog 比较好

@thinkasany
Copy link
Collaborator

是不是可以补充一个changelog @yutingzhao1991

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (d547f8f) to head (afc354f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #587    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          655       649     -6     
  Lines        17549     17411   -138     
  Branches      1059      1053     -6     
==========================================
- Hits         17549     17411   -138     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thinkasany
Copy link
Collaborator

后面这两个其实是不是应该也有对应的

image

@yutingzhao1991
Copy link
Collaborator Author

是不是也加一个 changelog 比较好

不用了,之前的 PR 还没发布

@yutingzhao1991 yutingzhao1991 merged commit 4d0ef72 into main Feb 27, 2024
12 checks passed
@yutingzhao1991 yutingzhao1991 deleted the fix/solcolorfulicon branch February 27, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants